Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade back to broker-api v10 #84

Open
wants to merge 3 commits into
base: gds_main
Choose a base branch
from
Open

Conversation

corlettb
Copy link

@corlettb corlettb commented Mar 14, 2024

What

Upgrade back to broker-api v10

Why

The previous problem seen in the broker acceptance tests was caused by the wrong import package being used.

The problem came down to this line.

It was comparing:

github.com/pivotal-cf/brokerapi/v10/domain/apiresponses.ErrInstanceDoesNotExist

with:

github.com/pivotal-cf/brokerapi/domain/apiresponses.ErrInstanceDoesNotExist

It was never going to match.

@jackjoy-gds jackjoy-gds self-assigned this Mar 14, 2024
Copy link

@jackjoy-gds jackjoy-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants