[ZD3454682] Set up VPC peering for DIT London #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://govuk.zendesk.com/agent/tickets/3454682: > Thanks for your response, and these are the details: > > Account ID: 588284153815 > VPC ID: vpc-03378ac5a1be3218d > VPC CIDR: 172.16.0.0/22 > Org/Space: dit-services / tap > > Account ID: 604925858717 > VPC ID: vpc-0338ce744086cd767 > VPC CIDR: 172.16.4.0/22 > Org/Space: dit-services / datasci
|
Can we hold off merging this for a moment while we work out what the naming etc should be. |
|
phewwww! I just pressed Ctrl+C when it was pushing |
|
Ok, I've had a read through the ticket etc, and I think this is good to go (sorry for the last minute alarm @keymon ) |
keymon
added a commit
that referenced
this pull request
Nov 15, 2018
[ZD3454682] Set up VPC peering for DIT London * commit '3defbea3428cfc374155fcd81fbf5f9aea52c58b': [ZD3454682] Set up VPC peering for DIT London
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Set up two new VPC peerings for DIT in prod-long, as per
https://govuk.zendesk.com/agent/tickets/3454682:
The concourse pipeline runs:
So even though the
prod-lon.vpc_peering.jsonfile is new it shouldJust Work(TM).
How to review
Who can review
Not @richardTowers