Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate jobs for PaaS services #1849

Merged
merged 8 commits into from Apr 15, 2019
Merged

Conversation

tlwr
Copy link
Contributor

@tlwr tlwr commented Apr 12, 2019

What

Within create-cloudfoundry pipeline

  • Move paas-accounts into its own Job
  • Move paas-admin into its own Job
  • Move paas-billing into its own Job
  • Move paas-metrics into its own Job

How to review

  • Code review commit-by-commit
  • Observe TLWR
  • Run it through your pipeline
  • Read ADR

Who can review

Not @tlwr

Toby Lorne added 8 commits April 12, 2019 13:49
The post-deploy job has too many things in it

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
The post-deploy job has too many things in it

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
The post-deploy job has too many things in it

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
The post-deploy job has too many things in it

This is annoying because paas-metrics is a subdirectory of paas-cf so it
will get deployed every time paas-cf changes. This doesn't really matter
though

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Separate out platform core and platform services to make the pipeline
easier to look at

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
When PaaS CF changes we want the services to get redeployed, so that any
secrets changed during a deploy are picked up automatically.

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
s/integration/acceptance

Signed-off-by: Toby Lorne <toby.lornewelch-richards@digital.cabinet-office.gov.uk>
@tlwr tlwr merged commit 72bb922 into master Apr 15, 2019
tlwr pushed a commit that referenced this pull request Apr 15, 2019
@tlwr tlwr deleted the separate-jobs-for-paas-services branch April 15, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants