Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to prometheus 29.2.0 #3191

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

corlettb
Copy link
Contributor

@corlettb corlettb commented May 9, 2023

What

Upgrade to prometheus 29.2.0.

We are using the 'attic' setting for now. There is a separate ticket to migrate to the latest firehose.

How to review

I deployed to dev03 in dev05.

Please deploy into a different dev environment and check it deploys okay.

Issue

I saw an issue when deploying that was hard to reproduce. Namely the error:

"Database locked, sleeping then retrying"

In the grafana log. My suspicion is that this problem is related to the monit change to use bpm in this release. There might be a timing issue where we end up with two grafana's running for a short amount of time. I resolved this when I saw it with a "bosh recreate".


馃毃鈿狅笍 Please do not merge this pull request via the GitHub UI 鈿狅笍馃毃

@corlettb corlettb force-pushed the benc-prometheus-boshrelease-28.2.0 branch 2 times, most recently from 187b8d6 to 1c6cd73 Compare May 10, 2023 12:26
@corlettb corlettb marked this pull request as ready for review May 10, 2023 14:46
@corlettb corlettb force-pushed the benc-prometheus-boshrelease-28.2.0 branch from 1c6cd73 to 5fea9ad Compare May 10, 2023 14:47
@corlettb corlettb changed the title Upgrade to prometheus 28.2.0 Upgrade to prometheus 29.2.0 May 10, 2023
@risicle
Copy link
Member

risicle commented May 10, 2023

So.. you think this is a glitch we'll only see the first time we migrate from a non-bpm-using grafana to a bpm-using grafana?

@risicle
Copy link
Member

risicle commented May 10, 2023

Shouldn't we be pointing to cloudfoundry/prometheus-boshrelease@173e7df ? This appears to point to its parent. Scratch that, it's just github showing it weirdly.

@corlettb
Copy link
Contributor Author

So.. you think this is a glitch we'll only see the first time we migrate from a non-bpm-using grafana to a bpm-using grafana?

I think it's an issue we "might" see. If we get another grafana instance in a bad state I'd like to examine it. I had difficulty reproducing it sadly.

@risicle risicle force-pushed the benc-prometheus-boshrelease-28.2.0 branch from 5fea9ad to 17d3357 Compare May 16, 2023 15:24
Copy link
Member

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM on dev05

@risicle risicle closed this May 17, 2023
@risicle risicle merged commit 04a60a0 into main May 17, 2023
8 checks passed
@risicle risicle deleted the benc-prometheus-boshrelease-28.2.0 branch May 17, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants