Refreshed app-autoscaler base manifest switch #3199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this involves moving almost all jobs out into their own instance groups and changing a lot of naming to be based on ((deployment_name)), meaning quite a bit of hostname adaptation etc
dark5un
changed the title
|
is this still relevant now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
https://www.pivotaltracker.com/story/show/184549339
This involves moving almost all jobs out into their own instance groups and changing a lot of naming to be based on ((deployment_name)), meaning quite a bit of hostname adaptation etc.
It also currently points manifests/app-autoscaler/upstream at our own fork until cloudfoundry/app-autoscaler-release#1653 or a similar fix makes it upstream. Left as a draft until that happens (or we abandon all hope).
(This also means this is likely to bump to the latest autoscaler version once that happens so we can include that change)
How to review
Deploy to a dev env, see the autoscaler acceptance tests passing.
Check the dev env's alertmanager (https://alertmanager-1.) to ensure AppAutoscalingIsNotScalingSingleProc and AppAutoscalingIsNotScalingMultiProc alerts aren't going off.
馃毃鈿狅笍 Please do not merge this pull request via the GitHub UI 鈿狅笍 馃毃