Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.21 #3645

Merged
merged 9 commits into from
Mar 25, 2024
Merged

Update to go 1.21 #3645

merged 9 commits into from
Mar 25, 2024

Conversation

monotypical
Copy link
Contributor

@monotypical monotypical commented Mar 11, 2024

What

Update go to 1.21 from 1.20.

Related PRs

alphagov/paas-aiven-broker#54
alphagov/paas-billing#196
alphagov/paas-accounts#39
alphagov/paas-auditor#25
alphagov/paas-rubbernecker#99
alphagov/paas-bootstrap#740
alphagov/paas-elasticache-broker#52
alphagov/paas-rds-broker#195
alphagov/paas-cdn-broker#82
alphagov/paas-s3-broker#63
alphagov/paas-sqs-broker#40

How to review

  • Deploy this branch to a dev env and update the branch/tag filters on the other repo resources to point to the go 1.21 branch.
  • Ensure that the pipeline runs and the tests succeed.
  • Ensure that apps are using go 1.21 by running cf env <app> | grep GOVERSION, e.g.
❯ cf env paas-prometheus-endpoint-redis | grep GOVERSION
GOVERSION: go1.21

🚨⚠️ The related PRs need to be merged first before this one, and then the tag filters on this PR will need to be updated ⚠️🚨

🚨⚠️ Please do not merge this pull request via the GitHub UI ⚠️🚨

@monotypical monotypical force-pushed the 187200424-update-to-go-1-21 branch 2 times, most recently from df0b928 to 038283d Compare March 13, 2024 14:58
Signed-off-by: Panos Xynos <panos.xynos@digital.cabinet-office.gov.uk>
@dark5un dark5un added the WIP DO NOT MERGE label Mar 15, 2024
Copy link
Contributor

@jackjoy-gds jackjoy-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@monotypical monotypical marked this pull request as ready for review March 25, 2024 11:39
@monotypical monotypical removed the WIP DO NOT MERGE label Mar 25, 2024
Copy link
Contributor

@dark5un dark5un left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@monotypical monotypical merged commit f548bf7 into main Mar 25, 2024
8 checks passed
@monotypical monotypical deleted the 187200424-update-to-go-1-21 branch March 25, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants