Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom domains content overhaul #187

Merged
merged 1 commit into from Dec 5, 2018
Merged

Custom domains content overhaul #187

merged 1 commit into from Dec 5, 2018

Conversation

jonathanglassman
Copy link
Contributor

What

  • Added in warning on domains’ TLS certificates failing to renew
  • Brought content in line with style
  • Improved structure:
    • Setting up a cdn-route service with one or more custom domains
    • Adding a custom domain to your existing cdn-route service
    • Mapping a subdomain route to your app
    • Removing a custom domain from your cdn-route service

How to review

Describe the steps required to test the changes.

  1. Preview the content locally (see README) and check that it renders as expected.
  2. Manually check that any removed or renamed anchor tags are not in use (linkchecker doesn't do this).
  3. Check it covers https://www.pivotaltracker.com/story/show/161837922

Who can review

Anyone except Jon Glassman or Jonathan Matthews

jpluscplusm
jpluscplusm suggested changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@jpluscplusm jpluscplusm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor comments.

source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
@jonathanglassman jonathanglassman changed the title [WIP] Custom domains content overhaul Custom domains content overhaul Dec 3, 2018
@alext alext self-assigned this Dec 4, 2018
alext
alext suggested changes Dec 4, 2018
View reviewed changes
Copy link
Contributor

@alext alext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - much clearer. I've left a few comments below.

source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
source/documentation/deploying_services/use_a_custom_domain.md Outdated Show resolved Hide resolved
@jpluscplusm
Copy link
Contributor

Go go team words!

@jonathanglassman @alext
Custom domains rewrite
5f3c1c2 
- Reorganised "Managing custom domains using the cdn-route service" section
- Added new sections: "Setting up a cdn-route service with one or more custom domains" and "Adding a custom domain to your existing cdn-route service"
- Added warnings on TLS certificates and migrating an existing service
@alext alext merged commit 3dcf700 into master Dec 5, 2018
@alext alext deleted the custom-domains-warning branch December 5, 2018 13:59
@jonathanglassman
Copy link
Contributor Author

Still waiting on 2i but it's fine I'll amend afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alext alext alext approved these changes

@jpluscplusm jpluscplusm jpluscplusm approved these changes

Assignees

@alext alext

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonathanglassman @jpluscplusm @alext