Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-11279: Run the connector-adminusers messaging pact test #2255

Merged
merged 2 commits into from Nov 16, 2023
Merged

PP-11279: Run the connector-adminusers messaging pact test #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63d1cef
PP-11279: Run the connector-adminusers messaging pact test
oswaldquek Nov 16, 2023
9b2dee5
trying remove xercesimpl
oswaldquek Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 2 additions & 8 deletions pom.xml
View file
Open in desktop
Expand Up @@ -323,14 +323,8 @@
</dependency>
<dependency>
<groupId>au.com.dius</groupId>
<artifactId>pact-jvm-provider-junit_2.12</artifactId>
<version>${pact.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>au.com.dius</groupId>
<artifactId>pact-jvm-consumer-junit_2.12</artifactId>
<version>${pact.version}</version>
<artifactId>pact-jvm-provider-junit</artifactId>
<version>4.0.10</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is ${pact.version} still used anywhere? If not, can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still being used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it’s only used in one place — can we remove the variable and just actual value where the variable used to be used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of think we should keep the <pact.version> property as we'll probably want to upgrade everything to 4.0.10 someday.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that’s the time to reintroduce the variable!

<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/uk/gov/pay/adminusers/pact/ConnectorQueueMessageContractTest.java
View file
Open in desktop
Expand Up @@ -8,7 +8,7 @@
import org.junit.runner.RunWith;

@RunWith(PactRunner.class)
@Provider("connector")
@Provider("adminusers")
@PactBroker(scheme = "https", host = "${PACT_BROKER_HOST:pact-broker.deploy.payments.service.gov.uk}", tags = {"${PACT_CONSUMER_TAG}", "test-fargate"},
authentication = @PactBrokerAuth(username = "${PACT_BROKER_USERNAME}", password = "${PACT_BROKER_PASSWORD}"),
consumers = {"connector"})
Expand Down