Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.eclipse.persistence.jpa from 2.7.7 to 3.0.0 #910

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 9, 2020

Bumps org.eclipse.persistence.jpa from 2.7.7 to 3.0.0.

Release notes

Sourced from org.eclipse.persistence.jpa's releases.

3.0.0-M1

  • initial version based on jakarta APIs
  • Maven-based build system
  • limited JPMS support by means of using Automatic-module-names
  • dropped Eclipse RCP integration features
  • dropped p2 update sites

Get standalone binary distribution

Commits
  • 3986bdb Update ECLIPSELINK version of org.eclipse.persistence:org.eclipse.persistence...
  • 87e9d14 CriteriaBuilderImpl fix revert and code improvement in DatabaseAccessor to fi...
  • 2db87cc #567891: improving fix to pass TCKs (#983)
  • 7d9ce3b CriteriaBuilderImpl fix set type in toString() (#982)
  • 5454299 Update ECLIPSELINK version of org.eclipse.persistence:org.eclipse.persistence...
  • e7b377c Update ECLIPSELINK version of org.eclipse.persistence:org.eclipse.persistence...
  • 06cd067 Integrate weld 4.0.0.CR1 (#978)
  • 67f41de Integrate glassfish-corba 4.2.3 (#977)
  • 714b541 Maven build and release script fix. (#976)
  • 5c0d1cd Add doPriv blocks to use of ThreadMXBean in ConcurrencyUtil (#975)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file govuk-pay java Pull requests that update Java code labels Dec 9, 2020
@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/org.eclipse.persistence-org.eclipse.persistence.jpa-3.0.0 branch 4 times, most recently from 7b4db66 to 012f8e0 Compare December 18, 2020 10:19
@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/org.eclipse.persistence-org.eclipse.persistence.jpa-3.0.0 branch 2 times, most recently from 1e8f9c7 to 332930c Compare December 22, 2020 17:51
Bumps [org.eclipse.persistence.jpa](https://github.com/eclipse-ee4j/eclipselink) from 2.7.7 to 3.0.0.
- [Release notes](https://github.com/eclipse-ee4j/eclipselink/releases)
- [Commits](eclipse-ee4j/eclipselink@2.7.7...3.0.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/org.eclipse.persistence-org.eclipse.persistence.jpa-3.0.0 branch from 332930c to ab7ed44 Compare December 23, 2020 12:48
@oswaldquek
Copy link
Contributor

oswaldquek commented Dec 31, 2020

Even after updating the imports, sadly Guice doesn't want to play:

java.lang.NoClassDefFoundError: javax/persistence/EntityManager

	at com.google.inject.persist.jpa.JpaPersistModule.configurePersistence(JpaPersistModule.java:65)
	at com.google.inject.persist.PersistModule.configure(PersistModule.java:35)
	at com.google.inject.AbstractModule.configure(AbstractModule.java:62)
	at com.google.inject.spi.Elements$RecordingBinder.install(Elements.java:407)
	at com.google.inject.spi.Elements.getElements(Elements.java:108)
	at com.google.inject.internal.InjectorShell$Builder.build(InjectorShell.java:160)
	at com.google.inject.internal.InternalInjectorCreator.build(InternalInjectorCreator.java:107)
	at com.google.inject.Guice.createInjector(Guice.java:87)
	at com.google.inject.Guice.createInjector(Guice.java:69)
	at com.google.inject.Guice.createInjector(Guice.java:59)
	at uk.gov.pay.adminusers.infra.GuicedTestEnvironment.<init>(GuicedTestEnvironment.java:19)

Internally it's still using javax.persistence rather than jakarta.persistence. Updating Guice to 5.0.0-BETA-1 didn't help either.

@oswaldquek
Copy link
Contributor

This is dependent on Guice upgrade to use Jakarta google/guice#1383

@alexbishop1
Copy link
Contributor

EclipseLink 3 uses Jakarta EE 9 (with a new package namespace), which isn’t yet supported by Guice.

@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@alexbishop1 alexbishop1 deleted the dependabot/maven/org.eclipse.persistence-org.eclipse.persistence.jpa-3.0.0 branch January 11, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file govuk-pay java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants