Remove the GOV.UK PPA from our Puppet

[alexmuller]

1. I've added some packages that I know we need to our PPA - if you know of any I've missed, please let me know.
2. I'm not sure if this will remove the PPA from our machines, or if we need to purge it to do that. I'm also not sure it matters either way.
3. This will upgrade Nginx from 1.4.1 to 1.4.4, which fixes a security advisory. Again, this may only affect new machines. As far as I can tell we don't have a clean way to ensure a version of a class is used.

[tombooth]

I don't think it will remove it from our machines. Can we do a apt::ppa { 'badklfjg': ensure => absent } ?

[jystewart]

What are the advantages of maintaining multiple GDS PPAs?

Given that we're moving towards a shared GOV.UK/Performance Platform out of hours support operation won't having multiple sources for core packages increase the chance of confusion and/or the amount of work involved in deploying a security patch?

[tombooth]

Although deploy a security patch would require a little more work, blocking each other from upgrading the version of a package would be more of a pain. A security patch should be fairly swift to apply as when a package has been built for the GOV.UK PPA we can just copy it over to the Performance Platform PPA.

[jystewart]

I'm not entirely convinced, but this pull request isn't the place to discuss further so don't let my comments make the call in this case. Please do make sure that the ops manual(s) reflect the fact that there are multiple steps when upgrading something for both PP and GOV.UK.

[jabley]

To my mind, having multiple PPAs is a temporary thing, and there are good reasons for it. A better approach would be to have a shared apt repository, which I'm going to talk about with the relevant smart people Real Soon Now™.

[jabley]

I think this may need more work to actually remove the GOV.UK PPA.

vagrant@pp-development-1:~$ ll /etc/apt/sources.list.d/
total 32
drwxr-xr-x 2 root root 4096 Jan  7 11:24 ./
drwxr-xr-x 6 root root 4096 Jan  7 11:23 ../
-rw-r--r-- 1 root root   79 Jan  7 11:24 10gen.list
-rw-r--r-- 1 root root   79 Jan  7 11:24 10gen.list.save
-rw-r--r-- 1 root root  122 Jan  7 11:24 gds-govuk-precise.list
-rw-r--r-- 1 root root  122 Jan  7 11:24 gds-govuk-precise.list.save
-rw-r--r-- 1 root root  152 Jan  7 11:24 gds-performance-platform-precise.list
-rw-r--r-- 1 root root   53 Jan  7 11:24 sensu.list

[tombooth]

Interesting, might be a GDS module we rely on

[alexmuller]

Unfortunately we're not able to purge a PPA with the most recently released version of apt::ppa. It has been merged though.

I've upgraded apt anyway, because why not.

[tombooth]

DevOps them?

[alexmuller]

Will do 🚢 🇮🇹