[#178898815] alertmanager deployment: wait for ecs service to be stable before proceeding #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sidenote: working on this reminded me how much I'd like to get #473 merged because its annoying and nerve-wracking having every push you make potentially triggering multiple builds in unexpected orders. |
risicle
changed the title
…ceeding the hope is that a broken deployment will be caught even if the current release doesn't cause an ecs deployment.
risicle
force-pushed
the
ris-alertmanager-wait-ecs-services-stable-178898815
branch
from
1684fb4
to
cb020f5
Compare
tommrr
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hope is that a broken deployment will be caught even if the current release doesn't cause an ECS deployment.
This does seem to have the desired effect in practise when the deployment is deliberately broken.