Don't expand all topical event fields #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
changed the title
thomasleese
reviewed
Nov 2, 2018
| @@ -62,7 +62,7 @@ def details_fields(*fields) | |||
| { document_type: :redirect, fields: [] }, | |||
| { document_type: :gone, fields: [] }, | |||
| { document_type: :contact, fields: (DEFAULT_FIELDS + details_fields(:description, :title, :contact_form_links, :post_addresses, :email_addresses, :phone_numbers)) }, | |||
| { document_type: :topical_event, fields: DEFAULT_FIELDS_WITH_DETAILS }, | |||
| { document_type: :topical_event, fields: DEFAULT_FIELDS }, | |||
There was a problem hiding this comment.
I'm not sure exactly what it is, but I think you'll also want to change the one below placeholder_topical_event.
There aren't any fields from the topical_event details hash which are used in rendering, so limit the fields included in link expansion, this will also help with payload size which helps queue processing speed.
steventux
force-pushed
the
dont-expand-topical-event-fields
branch
from
3355b81
to
87f04fc
Compare
thomasleese
approved these changes
Nov 2, 2018
steventux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There aren't any fields from the topical event details hash which are used in rendering.
The rendering is done by Whitehall but for some formats metatags depend on the content store content item, these don't apply to topical events though, so limit the fields included in link expansion, this will also help with payload size which helps queue processing speed.
DNM until I've done some testing