This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Move GitHub 'pending' status update before the lock #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the GitHub status of a publishing-e2e-tests check _before_ then waiting for a machine to run the tests on. We quite often have a queue of tests waiting to run (e.g. in a mass dependabot upgrade across multiple repositories). If the tests are being flaky, the lack of visibility over the status can exacerbate the problem as we may accidentally queue up several test re-runs for the same PR.
kevindew
approved these changes
Feb 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the GitHub status of a publishing-e2e-tests check before then waiting for a machine to run the tests on.
We quite often have a queue of tests waiting to run (e.g. in a mass dependabot upgrade across multiple repositories).
If the tests are being flaky, the lack of visibility over the status can exacerbate the problem as we may accidentally queue up several test re-runs for the same PR.