This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Add deps to finder-frontend #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The world locations API test helpers in gds-api-adapters have been fixed so that they point at `Plek.new.website_root` now. Finder-frontend relies upon the world locations API to populate the world locations facet, so until this is fixed in some way, we need to include router to handle those requests.
bilbof
approved these changes
Feb 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The world locations API test helpers in gds-api-adapters have been changed so that they point at
Plek.new.website_rootnow.Finder-frontend relies upon the world locations API to populate the world locations facet, so until this is fixed in some way, we need to include router to handle those requests.
It's making the PR to update gds-api-adapters on finder-frontend fail end to end tests.