Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

Some TLC #381

Merged
merged 4 commits into from
May 6, 2020
Merged

Some TLC #381

merged 4 commits into from
May 6, 2020

Conversation

kevindew
Copy link
Member

@kevindew kevindew commented May 6, 2020

In an attempt to not fully understand why we're checking ETXTBSY issues that are breaking tests (it seems to be that we're checking Chrome version while executing) I've done some basic updates to get things up to date. I've updated all gems, removed some unnecessary node installation in the e2e docker file and fixed linting issues.

Assuming this doesn't fix the problem (I can't see a good reason it would) here are some ideas:

  • we turn off parallel tests and deal with the extra time (I believe the problem is one rspec process is trying to replace the chrome binary while the other is updating it)
  • we do a grim monkey patch to disable Webdrivers from updating the binary - it won't actually need updating as this is done as part of building the Docker image
  • we set different chrome paths for each test worker which means they all have their own version of chrome installed so can't conflict.

All don't sound very nice. I wonder if what is happening is that we've somehow got a mismatch between chrome versions and webdriver version so we're trying to update repeatedly?

These dependencies aren't managed by dependabot.
This was a relic from phantomjs
Done with rubocop -a, added an exclusion for apps so we don't also lint
other repos.
Copy link
Contributor

@1pretz1 1pretz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🤞

Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 👏 thanks Kevin!

@kevindew kevindew merged commit 2203547 into master May 6, 2020
@kevindew kevindew deleted the webdrivers-tlc branch May 6, 2020 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants