This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
Remove unnecessary asset configuration #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these apps no longer need this configuration as they no longer use this hostname to serve assets. Instead they all have ASSET_HOST environment variables that specify their own hostnames for serving assets from.
thomasleese
approved these changes
Jun 17, 2020
I know - if only we could get rid of the custom asset-manager configuration we could lose this whole custom nginx config |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/oNEtjIVp/99-serve-static-assets-from-www-hostname
All of these apps no longer need this configuration as they no longer
use this hostname to serve assets. Instead they all have ASSET_HOST
environment variables that specify their own hostnames for serving
assets from.