Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update require in line with Rack's renaming #6

Closed
wants to merge 2 commits into from
Closed

update require in line with Rack's renaming #6

wants to merge 2 commits into from

Conversation

anicholson
Copy link

Fixes #5.

boffbowsh
boffbowsh suggested changes Oct 11, 2016
View reviewed changes
Copy link
Contributor

@boffbowsh boffbowsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break for rack < 2. Could you add a conditional or a rescue and fallback please?
Add your review

@anicholson
Copy link
Author

Good idea. Done! Thanks @boffbowsh :)

@boffbowsh
Copy link
Contributor

Thanks. FYI before I merge this I want to add some matrix testing to this repository so we can test the gem against rack pre- and post-2, and also against a few Ruby versions. I'll try to get to this today or tomorrow.

@boffbowsh boffbowsh mentioned this pull request Oct 13, 2016
Merged
@boffbowsh
Copy link
Contributor

Closing in favour of #7

@boffbowsh boffbowsh closed this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boffbowsh boffbowsh boffbowsh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anicholson @boffbowsh