Add Dockerfile and .dockerignore #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new `publishing-e2e-docker` project requires each dependent project to have a Dockerfile.
dougdroper
approved these changes
Nov 23, 2016
timblair
reviewed
Nov 25, 2016
|
|
||
| ADD . /go/src/github.com/alphagov/router | ||
|
|
||
| RUN go get github.com/tools/godep |
There was a problem hiding this comment.
You shouldn't need this. Godep is a tool to manage dependencies and place the correct versions in to /vendor/: it's a dev-only task, and isn't required to build the project.
There was a problem hiding this comment.
Thanks - I'll see if it works without it.
govuk-ci
pushed a commit
that referenced
this pull request
Oct 9, 2017
Add missing `require` to fix post-deployment Slack announcements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
publishing-e2e-dockerproject requires each dependent projectto have a Dockerfile.