Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning caused by config/default.yml #17

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Fix deprecation warning caused by config/default.yml #17

merged 1 commit into from
Mar 5, 2020

Conversation

duncanjbrown
Copy link
Contributor

@duncanjbrown duncanjbrown commented Mar 4, 2020

AllCops/Excludes works but causes a deprecation warning saying it was renamed to AllCops/Exclude. We bumped into this during the upgrade to 3.0.0 (DFE-Digital/apply-for-teacher-training#1525)

`AllCops/Excludes` works but causes a deprecation warning saying it was renamed to `AllCops/Exclude`
Copy link
Contributor

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, @duncanjbrown! 🥇

@issyl0 issyl0 merged commit 6e665d4 into alphagov:master Mar 5, 2020
issyl0 added a commit that referenced this pull request Mar 5, 2020
issyl0 pushed a commit that referenced this pull request Mar 5, 2020
@duncanjbrown duncanjbrown deleted the patch-1 branch March 5, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants