Topic form improvements #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbaines
approved these changes
Feb 13, 2017
This re-orders the topic form to be consistent with the guide form – with title, path and then description. At present we still need to differentiate between slug (used on the guide form) and path (used on the topic form) because the Guide form is only asking for a slug for the title (my-first-guide) whereas the Topic form expects an entire path (/service-manual/my-first-topic).
Bootstrap expects a help-block to be a <span> without paragraph elements around the contained text.
For consistency with the guide form, use the same field type for the same field.
36degrees
force-pushed
the
topic-form-fixes
branch
from
3eef7c9
to
dc5d8f7
Compare
|
Thanks for the review @cbaines! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
https://trello.com/c/ED6wNNn5/444-re-order-top-fields-of-the-topics-edit-pages-in-the-pub-app