Remove <abbr> tag from API Users table #2344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tooltip was on our list of things that don't seem like they'd comply with the design system. I've now spoken to a few recent and frequent users of the API Users index page and of the ones who knew this feature existed, none have used it, so I'm happy to remove it. The tests that used this feature are now using the API User edit page to get that information.
In my previous commit, I introduced some pretty unreadable assertions into this test. This is an attempt to improve the situation, but I reckon it could still be much better
chrisroos
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/dggyhTVY/62-api-users-page-fix-and-iterate-how-this-page-is-displayed
This tooltip was on our list of things that don't seem like they'd
comply with the design system.
So far I haven't found anybody who uses this feature.
Used to look like this:
Now it doesn't:
