Make autocomplete arrow button work #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's an [ongoing issue][1] with the accessible autocomplete that stops the arrow from opening the options menu when `showAllValues: true` is enabled. The `showAllValues: true` option shows all values when focused on the autocomplete element without having typed anything I tried getting this to work in Capybara with Selenium in `granting_permissions_test.rb` and `account_applications_test.rb`, but the click event listener on the arrow is making it a challenge to click on it in a test. Per the Jasmine test, you need to dispatch a click event rather than just using the `click()` method directly. I tried doing this in the Capybara test with `execute_script` and various other methods, but couldn't get the right results Instead, I've opted for a small single function Jasmine test This also hides the arrow when the autocomplete input is focused. Initially I wanted to make the arrow stay but have it toggle the menu, but I was trying to do this by checking whether the input was the active element, and it's no longer the active element once you click on the arrow! I didn't want to get into storing state in a variable, as there's too much under the hood autocomplete functionality that would affect visibility and therefore make the conditional logic complicated [1]: alphagov/accessible-autocomplete#202
yndajas
force-pushed
the
make-autocomplete-arrow-work
branch
from
7b98a31
to
fc1bda3
Compare
brucebolt
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
There's an ongoing issue with the accessible autocomplete that stops the arrow from opening the options menu when
showAllValues: trueis enabled. TheshowAllValues: trueoption shows all values when focused on the autocomplete element without having typed anything. This somewhat fixes the behaviour in SignonScreen recording
Current behaviour
Screen.Recording.2024-06-05.at.15.21.52.mov
New behaviour
Screen.Recording.2024-06-05.at.15.21.19.mov
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.