Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta tags are getting added multiple way's across static and slimmer #195

Closed
mcgoooo opened this issue Apr 21, 2017 · 1 comment
Closed

Comments

@mcgoooo
Copy link
Contributor

mcgoooo commented Apr 21, 2017

We currently are adding meta tags in multiple ways, we should decide on one and stick with it i think. generally recommend to remove from slimmer and use normal templating.

alphagov/static#1006

https://github.com/alphagov/static/blob/e87cdf94a86dba24f9609b980461fbb7386b47d2/app/views/govuk_component/analytics_meta_tags.raw.html.erb

https://github.com/alphagov/slimmer/blob/master/lib/slimmer/processors/metadata_inserter.rb#L15

@tijmenb
Copy link
Contributor

tijmenb commented Mar 27, 2018

This is going to be fixed by retiring static: https://trello.com/c/zLiC5VwG

@tijmenb tijmenb closed this as completed Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants