Add schema name analytics meta tag #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has dimension 17 been set up in our analytics profile(s)? |
|
@fofr yes it has, Paul Cronk will turn it on as soon as we merge and deploy this. |
fofr
approved these changes
Apr 21, 2017
|
i think we should keep all this code centralised not fussed where, and does not block release, just making you aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://trello.com/c/0xPPAdDd/286-track-schema-name-in-google-analytics
Paired with @michaelihejirika
Also tested locally with government-frontend and can confirm calls to GA with dimension17 are set correctly.