Set the default template to be core_layout #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can migrate off the current `wrapper` layout change the default template to be `core_layout`. All existing apps will need to be updated to explicitly call wrapper if they were previously just relying on that being the default.
dsingleton
added a commit
that referenced
this pull request
Aug 25, 2015
Set the default template to be core_layout
|
👍 It's makes it clearer the direction slimmer/static layouts are taking, and something using wrapper is exceptional/legacy. |
dsingleton
pushed a commit
to alphagov/email-alert-frontend
that referenced
this pull request
Oct 2, 2015
This should be a no-op change to app behaviour. The Slimmer upgrade will cancel out the removal of explicitly setting slimmer template. Note; these leaves `include Slimmer::Headers` in `ApplicationController` as its depended on by `set_slimmer_dummy_artefact` in `EmailAlertSignupsController`. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps using legacy layout should set it explicitly, so they're easily identified as outliers to be fixed. Apps using `core_layout` shouldn't set slimmer template at all, which simplies the app controller code too. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/courts-frontend
that referenced
this pull request
Oct 2, 2015
Note; These seems like a dead-repo, but I want to get slimmer/template setting rolled out across all the apps. This should be a no-op change to app behaviour. The Slimmer upgrade will cancel out the removal of explicitly setting slimmer template. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps using legacy layout should set it explicitly, so they're easily identified as outliers to be fixed. Apps using `core_layout` shouldn't set slimmer template at all, which simplies the app controller code too. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/licence-finder
that referenced
this pull request
Oct 2, 2015
This should be a no-op change to app behaviour. The Slimmer default was 'wrapper' before the upgrade, and is not explicitly set. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use a modern layout; - `header_footer_only`: - Needs a `related` component - button styling - some formatting for "Popular licences" list - `core_layout`: - the above, plus... - breadcrumbs - heading (and subheading) styling [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/contacts-admin
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use `core_layout`: - breadcrumbs - using the modern grid helpers - using page title component [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/collections
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use `core_layout`: - breadcrumbs - using the modern grid helpers - using page title component [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/feedback
that referenced
this pull request
Oct 5, 2015
This should be a no-op change to app behaviour. The Slimmer default was 'wrapper' before the upgrade, and is not explicitly set. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use a modern layout; - `header_footer_only`: - buttons - subheading styles - `core_layout`: - the above, plus... - breadcrumbs [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/finder-frontend
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use `core_layout`, and it's actually very little, I think it would just need some tweaking of the local grid styles. Still, it's better to do that in a separate PR, so it can be reviewed/tested specifically. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/info-frontend
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with slimmer_template, which is easier to grep for than the other methods. Slimmer 9.0.0 switched to core_layout [1] as the default layout, which is the modern/recommend layout. Apps not yet using core_layout should be explicitly marked as such, so we can easily identify them as needing updating. I had a quick look at what would be required to use core_layout, and it's actually very little, I think it would just need some tweaking of the local grid styles. Still, it's better to do that in a separate PR, so it can be reviewed/tested specifically. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/manuals-frontend
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. Slimmer 9.0.0 switched to `core_layout` [1] as the default layout, which is the modern/recommend layout. Apps not yet using `core_layout` should be explicitly marked as such, so we can easily identify them as needing updating. Switching to core looks like it would be straightforward, removing the use of `.inner-block` to set the base grid, but i'd want to do that in a separate PR. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. `slimmer_template` is available directly from `Slimmer`, so I've removed the WH implementation. The template setting logic will stay the same for attachments, but is slightly cleaner, and doesn't use parens, to be consistent with use of `slimmer_template` elsewhere. This is a pretty minor change, but it bring WH inline with other FE apps, so its worth it for the consistency. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. `slimmer_template` is available directly from `Slimmer`, so I've removed the WH implementation. The template setting logic will stay the same for attachments, but is slightly cleaner, and doesn't use parens, to be consistent with use of `slimmer_template` elsewhere. This is a pretty minor change, but it bring WH inline with other FE apps, so its worth it for the consistency. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/whitehall
that referenced
this pull request
Oct 5, 2015
This is a no-op change to app behaviour. The same Slimmer layout is used as be before, but set in a simple, standardised way with `slimmer_template`, which is easier to grep for than the other methods. `slimmer_template` is available directly from `Slimmer`, so I've removed the WH implementation. The template setting logic will stay the same for attachments, but is slightly cleaner, and doesn't use parens, to be consistent with use of `slimmer_template` elsewhere. This is a pretty minor change, but it bring WH inline with other FE apps, so its worth it for the consistency. [1] alphagov/slimmer#136
dsingleton
pushed a commit
to alphagov/info-frontend
that referenced
this pull request
Oct 5, 2015
`core_layout` is the default layout since Slimmer 9.0.0 [1], and apps should be using it where possible. The advantage over `header_footer_only` is that `core_layout` sets a base grid/container for the main content, so apps don't need to replicate it each time. This switches the layout, but not overriding the default, and removes the grid/container code specific to this app. The SASS `grid_layout` isn't needed, but was including `measurements` which is relied on else where. [1] alphagov/slimmer#136
alex-ju
added a commit
to alphagov/static
that referenced
this pull request
Feb 9, 2021
When core_layout was declared default in slimmer [1] these tests shoul've been update to reflect that. [1] alphagov/slimmer#136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can migrate off the current
wrapperlayout change thedefault template to be
core_layout. All existing apps will need to beupdated to explicitly call wrapper if they were previously just relying
on that being the default.