Add a user agent header for all requests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tijmenb
force-pushed
the
add-user-agent
branch
2 times, most recently
from
35c074b
to
c99c7db
Compare
This will make it easier to add better logging.
Even if it's not set (and it's always set) an empty value is fine to send.
This will make it easier to see who is making the requests. The format for the UA is consistent with gds-api-adapters.
tijmenb
force-pushed
the
add-user-agent
branch
from
c99c7db
to
2726624
Compare
tijmenb
added a commit
to alphagov/smart-answers
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183
tijmenb
added a commit
to alphagov/collections
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`.
tijmenb
added a commit
to alphagov/smart-answers
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183
tijmenb
added a commit
to alphagov/calculators
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/calculators
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/calendars
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/smart-answers
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183
tijmenb
added a commit
to alphagov/calendars
that referenced
this pull request
Feb 22, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/multipage-frontend
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/licence-finder
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/licence-finder
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/multipage-frontend
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/feedback
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will prevent this app from making many needless requests to `static`. https://trello.com/c/D9HmkJwI
tijmenb
added a commit
to alphagov/frontend
that referenced
this pull request
Feb 23, 2017
This bumps slimmer to make it use the rails cache and send a user agent: - alphagov/slimmer#184 - alphagov/slimmer#183 It will probably not have much effect on this app, because the cache is configured correctly here. https://trello.com/c/D9HmkJwI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #183, this adds a
User-Agentheader to all requests tostatic, just like gds-api-adapters does. This will make it easier for us to see where requests come from.https://trello.com/c/D9HmkJwI