Allow setting environment from custom application #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AWS we want to run tests for the publishing and stack specific domains. We also need to add new variables to have the tests working. The smokey tests are called from Jenkins, as a job, via `jenkins.sh` script, and are also running as a service in the monitoring server. In both cases environment variables are first loaded from the environment or from a `/etc/smokey.sh` file, and then set with `govuk_setenv default`. This makes dificult to set up the right environment in first place and have tests running with more than one setting, so this change allows us to change the default `govuk_setenv` to load the environment from several Smokey applications.
|
What would the expected values of |
|
Something like 'smokey-publishing' to use settings for the publishing domain, and 'smokey-stack' to use settings for the stack domain |
issyl0
approved these changes
Dec 11, 2017
|
I do not believe this required for the time-being, so I am going to close it off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AWS we want to run tests for the publishing and stack specific
domains. We also need to add new variables to have the tests working.
The smokey tests are called from Jenkins, as a job, via
jenkins.shscript, and are also running as a service in the monitoring server. In
both cases environment variables are first loaded from the environment
or from a
/etc/smokey.shfile, and then set withgovuk_setenv default.This makes dificult to set up the right environment in first place and
have tests running with more than one setting, so this change allows us
to change the default
govuk_setenvto load the environment from severalSmokey applications.