Add more text options for email alerts

[rubenarakelyan]

This commit adds fields to most finders to define a separate email alert list title text which will be used when the normally generated string is too long (> 255 characters). It will be appended with a string of the form “x items”, where “x” is the number of selected topics and “items” is either the singular or plural string defined as email_filter_name.

Also reverts #984 since this is a more comprehensive solution.

Trello: https://trello.com/c/KTHRa4a0/422-fix-email-alert-api-errors-when-the-email-alert-short-name-is-longer-than-255-characters

Deployment checklist:

• Deploy specialist-publisher
• Run the rake task publishing_api:publish_finders to re-publish all the finders

[jennyd]

I'm not sure if this approach will work with GovDelivery, because it sounds like we would generate identical names for multiple topics. I've just tried to manually create a topic with the same name as an existing one (in our Integration account) and it errors, saying the name needs to be unique 😢 The API docs don't mention that constraint though.

We use the generated title as both name and short-name - it looks like only name needs to be unique, whereas the length error was on short-name, so there might be a way around those constraints. It would be simpler for our future plans to keep those two fields identical if possible, though. I can help you test on integration this afternoon if you like.

[rubenarakelyan]

Discussed with @jennyd: following this PR I will raise another PR for finder-frontend that splits the logic for title and short_name to be separate so that we can continue to set title as we do now and use new logic for short_name that limits it to 255 characters. This PR is ready for review.

[Davidslv]

🌻 🍯