Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade govuk_template to 0.22.2 #1072

Merged
merged 3 commits into from Jun 21, 2017
Merged

Upgrade govuk_template to 0.22.2 #1072

merged 3 commits into from Jun 21, 2017

Conversation

fofr
Copy link
Contributor

@fofr fofr commented Jun 19, 2017

https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

@elenatanasoiu @NickColley @h-lame

fofr and others added 3 commits June 19, 2017 10:35
Once govuk_template has been upgraded to v0.21.0 it will use a new batch of icons. The old ones no longer exist, and have been removed from the routes + tests.

See alphagov/govuk_template@82d9459 for the changes done to icons in govuk_template.
Old devices with old OSs may still request these old images, they
should receive a working image It’s acceptable to send them a higher
resolution image which they will downscale.

https://mathiasbynens.be/notes/touch-icons
Copy link
Contributor

@h-lame h-lame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect for the old icons is a nice touch!

@fofr fofr merged commit c4874c1 into master Jun 21, 2017
@fofr fofr deleted the bump-template-version branch June 21, 2017 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants