Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade govuk_template to 0.22.2 #1072

Merged
merged 3 commits into from Jun 21, 2017
Merged

Upgrade govuk_template to 0.22.2 #1072

merged 3 commits into from Jun 21, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 19, 2017

  • Reverts text-decoration-skip: ink
  • Updates Apple icons
  • Cherry-picks icon fix 0dd051d from #1008
  • Add redirects so that requests to old images still return an image

https://github.com/alphagov/govuk_template/blob/master/CHANGELOG.md

@elenatanasoiu @nickcolley @h-lame

fofr and others added 3 commits Jun 19, 2017
Once govuk_template has been upgraded to v0.21.0 it will use a new batch of icons. The old ones no longer exist, and have been removed from the routes + tests.

See alphagov/govuk_template@82d9459 for the changes done to icons in govuk_template.
Old devices with old OSs may still request these old images, they
should receive a working image It’s acceptable to send them a higher
resolution image which they will downscale.

https://mathiasbynens.be/notes/touch-icons
@fofr fofr requested review from h-lame and elenatanasoiu Jun 21, 2017
@h-lame
h-lame approved these changes Jun 21, 2017
Copy link
Contributor

@h-lame h-lame left a comment

The redirect for the old icons is a nice touch!

@fofr fofr merged commit c4874c1 into master Jun 21, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the bump-template-version branch Jun 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.