Update jasmine to 2.0.2 #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| #Example: prevent PhantomJS auto install, uses PhantomJS already on your path. | ||
| #Jasmine.configure do |config| | ||
| # config.prevent_phantomjs_auto_install = true |
There was a problem hiding this comment.
We want to enable this option (see jasmine/jasmine-gem#213). In our env phantomjs is managed by puppet. We don't want this gem downloading it from the internet on use.
|
@alext Done. |
Merged
added 3 commits
June 2, 2014 10:07
Also cleaned up the jasmine environment. Jasmine 2 uses poltergeist instead of selenium-webdriver and so is jenkins-friendly. Additionally, it's now possible to use the asset pipeline to include source assets instead of having to maintain a list in jasmine.yml. Tests do not pass (and didn't before this change).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also cleaned up the jasmine environment. Jasmine 2 uses phantomjs
instead of selenium-webdriver and so is jenkins-friendly. It's now possible
to use the asset pipeline to include source assets instead of having to
maintain a list in jasmine.yml.
JS unit tests do not pass (and didn't before this change). I'm going to make
a second pull request to fix the tests I can and remove those I can't.