Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom "other" keys behave like defined keys #778

Merged
merged 1 commit into from Apr 28, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 27, 2016

When passing in an empty array for “Part of” or “From”, these defined keys don’t render any content or title – this reduces the need for logic in the frontend application. An equivalent custom key, eg “Related guides”, if passed an empty array, would output "Related guides: " and then no content after it.

  • Update the other keys so they have the same behaviour and the components behave consistently.

screen shot 2016-04-27 at 12 46 22

cc @mgrassotti @dsingleton

When passing in an empty array for “Part of” or “From”, these defined
keys don’t render any content or title.

An equivalent custom key, eg “Related guides”, if passed an empty
array, would output “Related guides: “ and then no content after it.

Update the other keys so they have the same behaviour and the component
behaves consistently.
@boffbowsh boffbowsh merged commit 3b2b4b4 into master Apr 28, 2016
1 check passed
1 check passed
default "Build #1023 succeeded on Jenkins"
Details
@boffbowsh boffbowsh deleted the other-like-keys branch Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.