Make custom "other" keys behave like defined keys #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When passing in an empty array for “Part of” or “From”, these defined keys don’t render any content or title. An equivalent custom key, eg “Related guides”, if passed an empty array, would output “Related guides: “ and then no content after it. Update the other keys so they have the same behaviour and the component behaves consistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing in an empty array for “Part of” or “From”, these defined keys don’t render any content or title – this reduces the need for logic in the frontend application. An equivalent custom key, eg “Related guides”, if passed an empty array, would output "Related guides: " and then no content after it.
otherkeys so they have the same behaviour and the components behave consistently.cc @mgrassotti @dsingleton