This repository has been archived by the owner on May 10, 2019. It is now read-only.
Prefer blank lines around access modifiers #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no cop available to enforce our current "blank line before, nothing after" rule so we can only enforce this using humans. To reduce the burden we should change our guide to something that is enforcable by a cop (Style/EmptyLinesAroundAccessModifier) and is more in line with the global ruby community reckons expressed in https://github.com/bbatsov/ruby-style-guide#indent-public-private-protected.
|
Edit: Whoops, I seem to have restated everything you have said. In which case I'm 💯 on this. |
|
The removed words don't indicate why we prefer nothing after the modifier, so it seems like it's a no-brainer to follow the idiom instead. |
bradwright
added a commit
that referenced
this pull request
Jan 20, 2016
Prefer blank lines around access modifiers
h-lame
added a commit
to alphagov/govuk-lint
that referenced
this pull request
Jan 20, 2016
Now that alphagov/styleguides#83 is merged we should enforce this cop to keep blank line buffers around access modifiers.
h-lame
added a commit
to alphagov/govuk-lint
that referenced
this pull request
Jan 20, 2016
Now that alphagov/styleguides#83 is merged we should enforce this cop to keep blank line buffers around access modifiers. Update transgression in diff.rb to comply.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no cop available to enforce our current "blank line before, nothing after" rule so we can only enforce this using humans. To reduce the burden we should change our guide to something that is enforcable by a cop (Style/EmptyLinesAroundAccessModifier) and is more in line with the global ruby community reckons expressed in https://github.com/bbatsov/ruby-style-guide#indent-public-private-protected.
Assuming we're happy with this, I'll raise a PR to enable the relevant cop in https://github.com/alphagov/govuk-lint