Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "API Reference" to "Add an OpenAPI specification to your documentation" #81

Conversation

duncanjbrown
Copy link
Contributor

Context

We recently used this template to document an API, and very nearly missed the useful feature which automatically generates good-looking documentation from an OpenAPI spec. It was hidden under the the term "API reference", which is not very explicit.

Changes proposed in this pull request

Change the menu item "API reference" to "Incorporate an OpenAPI spec", and change the associated page title too.

While we're here, add a link to the swagger.io /about page to help those who don't know what OpenAPI is.

Guidance to review

a) agree/disagree that the existing menu item is a bit obscure
b) consider whether the replacement could be better worded

@@ -1,6 +1,6 @@
---
title: "API reference"
title: "Incorporate an OpenAPI spec"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Add an OpenAPI specification to your documentation"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's much better. Thank you. Will reword.

The term "API Reference" does not do a good job of explaining what this
feature actually is: a way to incorporate an OpenAPI spec into the
generated documentation.
@duncanjbrown duncanjbrown force-pushed the explicit-name-for-openapi-feature branch from d4958b2 to 283c683 Compare June 24, 2019 12:50
@duncanjbrown duncanjbrown changed the title Rename "API Reference" to "Incorporate an OpenAPI spec" Rename "API Reference" to "Add an OpenAPI specification to your documentation" Jun 24, 2019
@duncanjbrown
Copy link
Contributor Author

Reworded

@jonathanglassman jonathanglassman merged commit 251604e into alphagov:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants