Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the aria-expanded attribute to the correct element #238

Merged
merged 5 commits into from
Jul 16, 2021
Merged

Move the aria-expanded attribute to the correct element #238

merged 5 commits into from
Jul 16, 2021

Commits on Jun 21, 2021

  1. Apply aria-expanded to the trigger, not the expandable area 

    aria-controls is already set
    @colinbm
    colinbm committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    5b51590 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Refactor toggleHeading to be clearer about it's intentions 

    isOpen was initially set, to the *current* state. Subsequent controls
were inverting that. If we invert it at the beginning this becomes clearer
Note - also renamed to setOpen to signify intent.
    @colinbm
    colinbm committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4ba92c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Set the initial aria-expanded state on the trigger not the target

    @colinbm
    colinbm committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    f46aee7 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Changelog

    @colinbm
    colinbm committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    4855791 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2021

  1. Merge branch 'master' into accessibility-aria-expanded

    Colin Burn-Murdoch committed Jul 16, 2021
    Configuration menu
    Copy the full SHA
    f787af9 View commit details
    Browse the repository at this point in the history