Don't change the focus of the page on initial load #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking a nav link that is the main entry point for the page, the focus should start at the very beginning. There is the "Skip to main content" link to allow the user to bypass the nav. Some nav examples do not include a page, for in page navigation. In this case the fragment remains at level 1.
36degrees
reviewed
Jul 13, 2021
colinbm
force-pushed
the
accessibility-initial-focus
branch
from
4059f62
to
bb70a4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
On loading a page initially
foo.htmldo not change the URL tofoo.html#h1-iduntil scrolling past.Remove the fragment from the navigation for the
h1.Why
It is expected that focus will begin at the start of the page. Changing this is confusing for screen reader users.
Note
I'm not sure about the navigation change... in itself it's not confusing as the target fragment is clear in the clicked link, but it still seems like the link to the "page" rather than "position on page" should be at the beginning. I'm going to double check this with DAC, but welcome any thoughts.Confirmed this is correct approach with DAC.