Fix mark styles in Windows High Contrast Mode #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
force-pushed
the
ldeb-fix-hcm-search
branch
from
89a92a8
to
b7c66ce
Compare
In some browsers (IE11, Chromium-based browsers) the marked text in search results are unreadable with forced colour modes when the background is black because the text colour for `<mark>` elements is set to black. This commit fixes this by re-asserting that the marked text should be the same colour as the surrounding text. We also have to set `background-color: Canvas`, because in Firefox `background-color: transparent` is also ignored (unlike in IE11, Chromiums).
lfdebrux
force-pushed
the
ldeb-fix-hcm-search
branch
from
b7c66ce
to
c79b716
Compare
lfdebrux
added this to Triage
in Technical Documentation Template project board
via automation
lfdebrux
moved this from Triage
to Review
in Technical Documentation Template project board
zapthedingbat
approved these changes
Sep 27, 2021
Technical Documentation Template project board
automation
moved this from Review
to Reviewer approved
Sep 29, 2021
Technical Documentation Template project board
automation
moved this from Reviewer approved
to Done
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some browsers (IE11, Chromium-based browsers) the marked text in search results are unreadable with forced colour modes when the background is black because the text colour for
<mark>elements is set to black. This is especially present in Windows High Contrast Mode (HCM).This commit fixes this by re-asserting that the marked text should be the same colour as the surrounding text.
We also have to set
background-color: Canvas, because in Firefoxbackground-color: transparentis also ignored (unlike in IE11, Chromiums).Screenshots