Skip to content
This repository has been archived by the owner on Apr 4, 2018. It is now read-only.

Use mutli_json gem instead of json. #14

Merged
merged 1 commit into from
Sep 12, 2013
Merged

Use mutli_json gem instead of json. #14

merged 1 commit into from
Sep 12, 2013

Conversation

nosborn
Copy link
Contributor

@nosborn nosborn commented Sep 4, 2013

gemspec is missing an explicit dependency on the json gem. Switch to multi_json just because it's already required for fog.

@nosborn
Copy link
Contributor Author

nosborn commented Sep 12, 2013

Just to clarify, the gemspec is currently broken:

$ git clone https://github.com/alphagov/vcloud-box-spinner.git temp
...
$ cd temp
$ bundle install --standalone
...
$ bundle exec bin/vcloud-box-spinner 
./bin/../lib/provisioner/cli.rb:1:in `require': no such file to load -- json (LoadError)
    from ./bin/../lib/provisioner/cli.rb:1
    from bin/vcloud-box-spinner:4:in `require'
    from bin/vcloud-box-spinner:4

philandstuff added a commit that referenced this pull request Sep 12, 2013
Use mutli_json gem instead of json.

Merged after discussion with @danielabel
@philandstuff philandstuff merged commit 692b208 into alphagov:master Sep 12, 2013
@nosborn nosborn deleted the multi_json branch September 12, 2013 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants