Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stats announcements UI #1649

Merged
merged 24 commits into from Aug 11, 2014
Merged

Improve stats announcements UI #1649

merged 24 commits into from Aug 11, 2014

Commits on Aug 11, 2014

  1. Stub a whitehall admin front-end style guide

    * Tricky naming for this, as “style guide” and “front-end” are both
    already overloaded terms
    * Page is intended to have the same purpose as /style-guide in other
    admin apps, which documents design patterns that differ from Bootstrap
    fofr committed Aug 11, 2014
    Copy the full SHA
    59d249e View commit details
    Browse the repository at this point in the history
  2. Add grid example to whitehall style guide

    * Include Bootstrap 2.0.3 caveats
    fofr committed Aug 11, 2014
    Copy the full SHA
    08fcc9a View commit details
    Browse the repository at this point in the history
  3. Add form example to style guide

    * Indicates how default legend and fieldset styles create a layout that
    separates headings from content
    fofr committed Aug 11, 2014
    Copy the full SHA
    1f7f1ba View commit details
    Browse the repository at this point in the history
  4. Shim govuk_admin_template helpers into admin

    * Rather than porting Whitehall over to the template, which would take
    a long time, begin adapting some of the concepts the template introduces
    * Include CSS helper classes for admin UI
    * Include theme variables used within the template
    fofr committed Aug 11, 2014
    Copy the full SHA
    4d9d63b View commit details
    Browse the repository at this point in the history
  5. Emulate form styles used in govuk_admin_template

    * Use a class, form-large, to avoid applying this everywhere
    * Reset many of the styles applied by Bootstrap 2
    * Default to a larger font-size
    * Document styles in the style guide
    fofr committed Aug 11, 2014
    Copy the full SHA
    f2a4c0e View commit details
    Browse the repository at this point in the history
  6. Apply form-large styles to new stats announcement

    * Add form-large, form-group wrappers and form-control classes to form
    elements
    * Apply checkbox and radio styles directly to labels where appropriate
    — form builders make it harder to change the markup
    fofr committed Aug 11, 2014
    Copy the full SHA
    9af784a View commit details
    Browse the repository at this point in the history
  7. Create form helper for both save/cancel as buttons

    * Make the cancel action clearer by using a grey button style, but
    separate it from the main submit action to prevent accidental clicks
    * Create gutter classes and mixins to specify a large gap between
    elements, in this case two buttons
    fofr committed Aug 11, 2014
    Copy the full SHA
    537ece3 View commit details
    Browse the repository at this point in the history
  8. Cleanup new stats, edit and change date templates

    * Move or (remove where appropriate) the warning message to render grid
    correctly
    * Remove warning message when performing an edit action, presume that
    at this point the user understands the consequences of these actions
    * Create styles for item and actions within a header, this ought to be
    extracted into a generic pattern at a later date
    fofr committed Aug 11, 2014
    Copy the full SHA
    1941220 View commit details
    Browse the repository at this point in the history
  9. Update button wording to indicate publish

    * When a stats announcement is created, edited or has its date changed,
    the changes are immediately published — the button text needs to make
    this clear
    fofr committed Aug 11, 2014
    Copy the full SHA
    9ff9e81 View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    6602449 View commit details
    Browse the repository at this point in the history
  11. Cleanup stats announcements list

    * Put header at the top of the page
    * Move warning down and give better vertical spacing to create
    announcement action
    * Rename search to filter to match other filter forms on Whitehall
    * Make the search button a Bootstrap styled button
    fofr committed Aug 11, 2014
    Copy the full SHA
    b6a1312 View commit details
    Browse the repository at this point in the history
  12. Port table header styles from admin template

    * Add table example to style guide
    * Include styles for table header and secondary table headers
    fofr committed Aug 11, 2014
    Copy the full SHA
    0eab779 View commit details
    Browse the repository at this point in the history
  13. Apply ported table styles to stats listing

    * Give the table a prominent header consistent with other admin apps
    fofr committed Aug 11, 2014
    Copy the full SHA
    983ee58 View commit details
    Browse the repository at this point in the history
  14. Port and apply no content styles from admin gem

    * A large but light style which applies to the empty state.
    * Apply when no statistics announcements are found by a filter
    fofr committed Aug 11, 2014
    Copy the full SHA
    c3cecec View commit details
    Browse the repository at this point in the history
  15. Cleanup stats announcement page

    * Indicate statistics type above title, matching front-end
    * Clarify the view on website link, specifying which site
    * Remove the warning message and fix grid layout of page
    * Format details and summary in the same style as used on the front-end
    * Remove delete announcement button
    fofr committed Aug 11, 2014
    Copy the full SHA
    51083ab View commit details
    Browse the repository at this point in the history
  16. Cleanup document linker

    * Delete existing overrides and inline styles
    * Update language from “linking” to “connecting” to avoid confusion
    related to behaviour of legacy systems, as observed in user research
    * Re-style document finder, which uses IDs for styles and javascript
    which makes refactoring or overriding styles difficult
    fofr committed Aug 11, 2014
    Copy the full SHA
    b9cba28 View commit details
    Browse the repository at this point in the history
  17. Make stats forms more mobile friendly

    * Using span8 grid classes meant that form elements were always a
    percentage width of the viewport, at small widths this doesn’t make
    sense
    * Use max-widths instead, the form expands up to a certain point, but
    on smaller viewports elements take up more of the limited screen space
    * Apply the same logic to organisation and topic selects
    fofr committed Aug 11, 2014
    Copy the full SHA
    90c6bb4 View commit details
    Browse the repository at this point in the history
  18. Create block-label styles

    * Base on the pattern in GOV.UK elements, but use the existing
    Bootstrap palette, http://govuk-elements.herokuapp.com/#guide-forms
    * Add examples to style guide
    * Currently missing the javascript focus and selected styles
    fofr committed Aug 11, 2014
    Copy the full SHA
    9e995b5 View commit details
    Browse the repository at this point in the history
  19. Use block labels in stats announcement forms

    * Provide better titles and descriptions for statistics types, and
    replace select with radio buttons for easier access to options
    * Use inline block labels for display precision
    fofr committed Aug 11, 2014
    Copy the full SHA
    301f13c View commit details
    Browse the repository at this point in the history
  20. Dynamically update example date precision

    * Show users the exact date that will be published and shown to users
    based on their choices. (As announcements are published immediately,
    they otherwise wouldn’t see it until it was live)
    * Exact date, one month range, two month range and whether the date is
    provisional or not
    fofr committed Aug 11, 2014
    Copy the full SHA
    a6e28f1 View commit details
    Browse the repository at this point in the history
  21. Copy the full SHA
    f3a20b7 View commit details
    Browse the repository at this point in the history
  22. Alter stats heading classes

    * Avoid inferring semantics, the styles should be usable with any
    content
    * Don’t nest divs within headings, that’s not valid HTML
    fofr committed Aug 11, 2014
    Copy the full SHA
    be6c99d View commit details
    Browse the repository at this point in the history
  23. Rename admin template files as SASS partials

    * Files aren’t intended to be compiled and used by themselves
    * Use _ to indicate that they are partials —
    http://sass-lang.com/guide#topic-4
    fofr committed Aug 11, 2014
    Copy the full SHA
    b6c3fac View commit details
    Browse the repository at this point in the history
  24. Move stats CSS to helpers

    * The stats CSS applies to a set of pages across a couple of
    controllers, and isn’t restricted based on the usual controller
    generated classnames
    * Because it doesn’t meet the usual rules for styles specific to views,
    it should live elsewhere
    fofr committed Aug 11, 2014
    Copy the full SHA
    e618782 View commit details
    Browse the repository at this point in the history