Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creating or modifying policies & supporting pages. #2104

Merged
merged 4 commits into from Apr 24, 2015

Conversation

elliotcm
Copy link
Contributor

There is an entry in the election team tech debt
page to fully remove all of the remaining code,
this is just to prevent further modifications now
that policies are handled by the Policy Publisher.

https://trello.com/c/lCV3MbSO/201-disable-creating-and-editing-of-policies-in-whitehall

New document menu

screenshot 2015-04-21 15 12 29

Policies

screenshot 2015-04-24 14 10 30

Supporting pages

screenshot 2015-04-24 14 10 58

@elliotcm elliotcm force-pushed the disable-creating-and-editing-of-policies branch 2 times, most recently from 44c126f to 28a086d Compare April 21, 2015 14:25
@edds
Copy link
Contributor

edds commented Apr 21, 2015

👍 This looks good to me.

@elliotcm elliotcm force-pushed the disable-creating-and-editing-of-policies branch from 28a086d to 68660ae Compare April 21, 2015 15:06
@elliotcm
Copy link
Contributor Author

Followup from product; we need to refer users to GDS rather than policy publisher, and GDS admins should still be able to work as before to handle those requests.

@elliotcm elliotcm force-pushed the disable-creating-and-editing-of-policies branch from 9bbe890 to 349b495 Compare April 24, 2015 13:02
There is an entry in the election team tech debt
page to fully remove all of the remaining code,
this is just to prevent further modifications now
that policies are handled by the Policy Publisher.
These will be sorted out properly later by the
elections team.
This will be done on behalf of departments until
they have access to the new system.
@elliotcm elliotcm force-pushed the disable-creating-and-editing-of-policies branch from 349b495 to 96c4131 Compare April 24, 2015 13:13
@elliotcm
Copy link
Contributor Author

@edds Code updated, needs re-review.
@bmwelby Screenshots updated, need re-review.

@elliotcm
Copy link
Contributor Author

Product signoff from @bmwelby

@edds
Copy link
Contributor

edds commented Apr 24, 2015

👍

elliotcm added a commit that referenced this pull request Apr 24, 2015
@elliotcm elliotcm merged commit 901677c into master Apr 24, 2015
@elliotcm elliotcm deleted the disable-creating-and-editing-of-policies branch April 24, 2015 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants