Set inheritance for medium stacked custom logos #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not directly related to this change, more to the 1,000 line logo CSS file. It'd be nice to have a living style guide that showed all these variant logo types, so that changes and their affects on everything else could be quickly checked. |
| @@ -936,6 +936,10 @@ img.organisation-logo-custom { | |||
| @extend .organisation-logo-identity-medium; | |||
| border-left: none; | |||
| } | |||
| .organisation-logo-stacked-custom-medium { | |||
There was a problem hiding this comment.
The styles in this block are identical to the ones above. Should they be combined?
There was a problem hiding this comment.
They could be. I was just matching the style of all the other logos where they are split into two different blocks.
|
One minor comment, otherwise 👍 |
Without this inheritance the custom medium stacked logos don't get any font-size set on them. This makes them really small rather than the same size as the single identity logos. Remove the border that gets added during the inheritance call.
edds
force-pushed
the
medium-custom-logos
branch
from
2eeeb19
to
e515746
Compare
edds
added a commit
that referenced
this pull request
Aug 28, 2015
Set inheritance for medium stacked custom logos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this inheritance the custom medium stacked logos don't get any
font-size set on them. This makes them really small rather than the same
size as the single identity logos.
Remove the border that gets added during the inheritance call.
https://trello.com/c/CKqkyseM/80-bespoke-logos-display-small-text-small