Delete frontend parts of case studies #3332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fofr
commented
Jul 7, 2017
fofr
commented
- Case studies are rendered by government-frontend
- The template and controller aren’t used
- The route is still used to generate the case study base_path
* Case studies are rendered by government-frontend * The template and controller aren’t used * The route is still used to generate the case study base_path
6 tasks
fofr
force-pushed
the
delete-migrated-formats-frontend
branch
from
c51f786
to
5759472
Compare
* This logic doesn’t need to be handled by Whitehall * Note: government-frontend doesn’t do this redirect: https://www.gov.uk/government/case-studies/bis-criminal-prosecutions?loc ale=en
fofr
force-pushed
the
delete-migrated-formats-frontend
branch
from
5759472
to
d3ee9a3
Compare
gpeng
approved these changes
Jul 7, 2017
floehopper
added a commit
that referenced
this pull request
May 11, 2023
One of these log messages is generated for every asset file when running
the "default" rake task:
I, [2023-05-04T21:13:38.159080 #13071] INFO -- : Writing
/govuk/whitehall/public/assets/whitehall/manifest-2ea7d4701d69c26ab63627d91d5d337927c55fa4a46c819103de10e179b01b02.js
I don't think these log messages are particularly useful and in fact
they obscure what might be a significant warning:
W, [2023-05-05T10:44:04.253251 #3332] WARN -- : Removed sourceMappingURL comment for missing asset 'govuk_publishing_components/vendor/lux/lux.js.map' from /root/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/govuk_publishing_components-35.3.3/app/assets/javascripts/govuk_publishing_components/vendor/lux/lux-reporter.js
I'm not planning to address the latter in this commit, but with the
INFO-level messages now hidden, this should be more prominent!
I've redefined the rake tasks defined by sprockets-rails as recommended
in the documentation [1] in order to change the log_level from INFO to
WARN.
[1]: https://github.com/rails/sprockets-rails/blob/v3.4.2/README.md#customize
floehopper
added a commit
that referenced
this pull request
May 11, 2023
One of these log messages is generated for every asset file when running
the "default" rake task:
I, [2023-05-04T21:13:38.159080 #13071] INFO -- : Writing
/govuk/whitehall/public/assets/whitehall/manifest-2ea7d4701d69c26ab63627d91d5d337927c55fa4a46c819103de10e179b01b02.js
I don't think these log messages are particularly useful and in fact
they obscure what might be a significant warning:
W, [2023-05-05T10:44:04.253251 #3332] WARN -- : Removed sourceMappingURL comment for missing asset 'govuk_publishing_components/vendor/lux/lux.js.map' from /root/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/govuk_publishing_components-35.3.3/app/assets/javascripts/govuk_publishing_components/vendor/lux/lux-reporter.js
I'm not planning to address the latter in this commit, but with the
INFO-level messages now hidden, this should be more prominent!
I've redefined the rake tasks defined by sprockets-rails as recommended
in the documentation [1] in order to change the log_level from INFO to
WARN.
[1]: https://github.com/rails/sprockets-rails/blob/v3.4.2/README.md#customize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.