Remove publication templates #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuzz
force-pushed
the
remove-publication-templates
branch
2 times, most recently
from
7e82885
to
b3c3b56
Compare
|
🎉 Nice
|
rubenarakelyan
approved these changes
Aug 3, 2017
fofr
reviewed
Aug 3, 2017
|
|
||
| <div class="block-2 heading-block"> | ||
| <div class="inner-block"> | ||
| <%= render partial: "documents/attachment_full_width", |
There was a problem hiding this comment.
Can this partial also be removed? Looks like it was only referenced on publications and statistics.
|
Just the one thing I've found that could also be removed. 👍 💯 |
We can no longer test these changes are reflected on the show page, but we can still check the data has changed.
We can no longer test these changes are reflected on the show page, but we can still check the data has changed.
The show page no longer exists.
This feature is about to be removed as it will be handled via the draft stack. This feature was failing after removing publications#show there’s not much point fixing it.
We can no longer test these changes are reflected on the show page, but we can still check the data has changed.
We can no longer test these changes are reflected on the show page, but we can still check the data has changed.
We converted this to an admin feature that checks the data has been updated correctly in the database.
We converted this to an admin feature that checks the data has been updated correctly in the database.
We converted this to an admin feature that checks the data has been updated correctly in the database.
Attachments are far more thoroughly tested in features/edition-attachments.feature. The feature we removed relied on publications#show which no longer exists.
These features don’t interact with Whitehall admin, they directly set up data then visit the publications#show page to assert things. This page is now being served by government frontend so these feature can be removed.
tuzz
force-pushed
the
remove-publication-templates
branch
from
b3c3b56
to
69ebea7
Compare
|
Deployed to integration. Everything looks ok. Merging. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/kfyYY4tf/73-9-publications-migration-final-tasks-deploy-2-05-days
The rendering of these pages is now handled by government-frontend. This work removes this code from Whitehall and re-works some of the tests to equivalently test the things where assertions were previously made against these views.
It's probably easiest to review this commit-by-commit and read the commit messages.
The supersedes #3136 which deleted more code than was necessary.