WIP: Update asset routes #3629
Closed
WIP: Update asset routes #3629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Improve this commit message. It also avoids a potential problem of a path containing multiple periods. Imagine /government/uploads/file.name.png. params[:path] would contain `file`, params[:extension] would contain 'name' and params[:format] would contain 'png'. With this change, params[:path] contains 'file.name' and params[:format] contains 'png'.
As per the Route globbing and wildcard segments docs[1]: > If you want to make the format segment mandatory, so it cannot be omitted, you can supply format: true like this: We'd already made format mandatory by including the :format dynamic segment in the route. [1]: http://guides.rubyonrails.org/routing.html#route-globbing-and-wildcard-segments
TODO: Improve this commit message.
|
I'm abandoning this approach and going to fold this work into PR #3627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.