Fix highlighting of "Consultations" in main navigation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken by 4b5f570. This is a band-aid over the underlying problem that there are no tests keeping current_main_navigation_path in sync with the contents of the #global-nav element in website.html.erb. I haven't fixed that here since it requires a decision about whether to simply write such tests against the current code, or rewrite that code to remove duplication between #global-nav and the helper (e.g. use params instead of named route helpers in the main_navigation_link_to calls in #global-nav), or both.
lazyatom
added a commit
that referenced
this pull request
Feb 28, 2012
Fix highlighting of "Consultations" in main navigation
|
Thanks for this Tom! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by 4b5f570.
This is a band-aid over the underlying problem that there are no tests keeping
current_main_navigation_pathin sync with the contents of the#global-navelement inwebsite.html.erb.I haven't fixed that here since it requires a decision about whether to simply write such tests against the current code, or rewrite that code to remove duplication between
#global-navand the helper (e.g. use params instead of named route helpers in themain_navigation_link_tocalls in#global-nav), or both.