Fix a bug where specialist sectors wouldn't stick #4662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
approved these changes
Mar 5, 2019
Because this code was using `defined?` to check for the presence of the `specialist_sectors` method on the edition, and the edition is wrapped in a `LocalisedModel` which technically doesn't have that method defined, the code was replacing existing specialist sectors with recommended ones. Using `respond_to?` provides the correct behaviour since it accounts for `method_missing` in `LocalisedModel` and therefore uses duck typing to figure out whether it's safe to call `specialist_sectors` on the object.
elliotcm
force-pushed
the
fix-specialist-sectors
branch
from
af8848b
to
1af0c85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this code was using
defined?to check for the presence of thespecialist_sectorsmethod on the edition, and the edition is wrapped in aLocalisedModelwhich technically doesn't have that method defined, the code was replacing existing specialist sectors with recommended ones.Using
respond_to?provides the correct behaviour since it accounts formethod_missinginLocalisedModeland therefore uses duck typing to figure out whether it's safe to callspecialist_sectorson the object.https://trello.com/c/9OARj5Uf/813-topics-not-making-it-to-the-publishing-api-from-whitehall