Update World Location News and Topical Events templates #6147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-gds
force-pushed
the
update-world-location-to-gem
branch
5 times, most recently
from
b203771
to
4a0c79b
Compare
Merged
chris-gds
force-pushed
the
update-world-location-to-gem
branch
2 times, most recently
from
b2381a4
to
c6e2372
Compare
chris-gds
changed the title
chris-gds
force-pushed
the
update-world-location-to-gem
branch
5 times, most recently
from
d780940
to
bc78522
Compare
chris-gds
force-pushed
the
update-world-location-to-gem
branch
3 times, most recently
from
c2f96fc
to
e988a87
Compare
owenatgov
reviewed
Jul 16, 2021
chris-gds
force-pushed
the
update-world-location-to-gem
branch
2 times, most recently
from
5deb838
to
ffbd4b6
Compare
chris-gds
force-pushed
the
update-world-location-to-gem
branch
3 times, most recently
from
1fd5497
to
777b30f
Compare
owenatgov
reviewed
Oct 1, 2021
owenatgov
dismissed
their stale review
The PR has been added to so I'm withdrawing my approval until it's ready again
jon-kirwan
force-pushed
the
update-world-location-to-gem
branch
7 times, most recently
from
cf0fc29
to
e549539
Compare
owenatgov
reviewed
Oct 4, 2021
jon-kirwan
force-pushed
the
update-world-location-to-gem
branch
3 times, most recently
from
e2bb853
to
f436862
Compare
- Convert bespoke UI elements within "world-location" to use the component gem, applying Design System when appropriate including the layout. - Remove some redundant CSS - Semi-maintain shared elements that appear elsewhere - Include horizontal rule as part heading - Update testing Eg page: /world/organisations/british-embassy-moscow/about/recruitment /world/falkland-islands/news "document_list" & "translation_nav" swaps omitted (from this PR)
Altering shared files that generate document lists to align with an updated design Remove top margin
Improving nested headings within document lists
jon-kirwan
force-pushed
the
update-world-location-to-gem
branch
from
52b1114
to
e91c93c
Compare
Cheers Owen! Could I ask you to hit the merge button for me too 👍 (I've rebased the branch just now) |
owenatgov
changed the title
chris-gds
pushed a commit
that referenced
this pull request
Oct 8, 2021
Temporarily reverting as merge impacts "http://www.gov.uk/world/uk-and-the-commonwealth"
chris-gds
pushed a commit
that referenced
this pull request
Oct 8, 2021
Temporarily reverting as merge impacts "http://www.gov.uk/world/uk-and-the-commonwealth"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update World location news template to use components / the Design System
Why
On-going a11y work, to swap components, align architecture and, in turn, improve accessibility.
Visuals
Note (local "after" screenshots have missing images due to local data - this won't be an exact replica)
How to test
Only some pages have "statistics documents" one example can be found below:
/world/falkland-islands/news
Other example URLs:
/world/france/news
/world/new-zealand/news
Anything else
[DO NOT MERGE]
There are multiple files with
/app/views/sharedthat require updating across all templates in useeg:
recently_updatedappears on /world/uk-and-the-commonwealthSwapping
document_listandtranslation_navproved problematic, this has been omitted from this PR to be raised separately.There are known logical heading order issues on these pages. This should be addressed in the
document_listswapDuring this work I faced some local development issues, I've updated the README with some troubleshooting notes.