Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement paste to govspeak #6554

Merged
merged 3 commits into from May 13, 2022
Merged

Implement paste to govspeak #6554

merged 3 commits into from May 13, 2022

Conversation

DilwoarH
Copy link
Contributor

@DilwoarH DilwoarH commented May 11, 2022

What

Converts pasted formatted content to GovSpeak

Why

This work will reduce the effort and time for publishers to create new content, including HTML attachments and as a result, increase interest in creating HTML attachments by default

https://trello.com/c/c6hcyFgA/432-add-paste-html-to-govspeak-to-whitehall

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@DilwoarH DilwoarH requested a review from kevindew May 11, 2022 15:34
@DilwoarH DilwoarH force-pushed the paste-to-govspeak branch 3 times, most recently from b7e29aa to 414a6ae Compare May 11, 2022 16:47
Copy link
Member

@kevindew kevindew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good - nice one putting together the test. I've added a few suggestions.

app/assets/javascripts/admin/modules/paste_govspeak.js Outdated Show resolved Hide resolved
spec/javascripts/admin/modules/paste_govspeak.spec.js Outdated Show resolved Hide resolved
spec/javascripts/admin/modules/paste_govspeak.spec.js Outdated Show resolved Hide resolved
spec/javascripts/admin/modules/paste_govspeak.spec.js Outdated Show resolved Hide resolved
spec/javascripts/admin/modules/paste_govspeak.spec.js Outdated Show resolved Hide resolved
spec/javascripts/admin/modules/paste_govspeak.spec.js Outdated Show resolved Hide resolved
Dilwoar Hussain added 3 commits May 11, 2022 23:06
Converts pasted formatted content to GovSpeak

This work will reduce the effort and time for publishers to create new content, including HTML attachments and as a result, increase interest in creating HTML attachments by default
This will allow pasted content in previewable fields to be converted to Govspeak
Copy link
Contributor

@ollietreend ollietreend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻 looks good to me

@DilwoarH
Copy link
Contributor Author

I will merge this once JP has reviewed it on integration

@DilwoarH
Copy link
Contributor Author

I will merge this once JP has reviewed it on integration

JP signed off

@DilwoarH DilwoarH merged commit 352a8f7 into main May 13, 2022
@DilwoarH DilwoarH deleted the paste-to-govspeak branch May 13, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants