World_news show replace bootstrap with GDS #7450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did not create a helper for the tabs as it only appears on this page. Could be a extracted into helper refactor in the future |
davidgisbey
reviewed
Mar 17, 2023
davidgisbey
reviewed
Mar 17, 2023
davidgisbey
reviewed
Mar 17, 2023
|
Looking good. Just left a few comments. It'll need a lint too |
CL-GDS
force-pushed
the
world_news_replace_bootstrap_with_gds
branch
from
21cf168
to
c728e07
Compare
|
@CL-GDS
Reference: https://gds-wh.herokuapp.com/v2/organisation/ |
|
Is this ready to review or still draft? |
CL-GDS
force-pushed
the
world_news_replace_bootstrap_with_gds
branch
2 times, most recently
from
018d02a
to
d7995e5
Compare
|
RFR |
DilwoarH
reviewed
Mar 21, 2023
DilwoarH
reviewed
Mar 21, 2023
|
@cbernardojr-gds - not sure if I agree with the positioning of the Edit button - it just looks out of place. Can we try something else? |
DilwoarH
reviewed
Mar 21, 2023
|
The spacing between the view on website link needs to be fix. If you follow my suggestion here - this will be fixed |
CL-GDS
force-pushed
the
world_news_replace_bootstrap_with_gds
branch
from
d7995e5
to
0a34261
Compare
DilwoarH
reviewed
Mar 21, 2023
CL-GDS
force-pushed
the
world_news_replace_bootstrap_with_gds
branch
8 times, most recently
from
bffcf32
to
d02088f
Compare
|
RFR |
What * Dupe and Rename `show` * Dupe and Rename `controller_test` * Added `next_release` to `controller` * Added `layout` to `controller` * GDS to `show` Why * Show to GDS Trello https://trello.com/c/kNntszsl/51-world-location-news-show-page
# What Updated the `show` page to have open on website link open new tab from new Design Review # Why Align `view on website` link with new tab to pass new acceptence criteria
davidgisbey
force-pushed
the
world_news_replace_bootstrap_with_gds
branch
from
6f35ea1
to
fcccd25
Compare
davidgisbey
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
showcontroller_testnext_releasetocontrollerlayouttocontrollershowWhy
Trello
https://trello.com/c/kNntszsl/51-world-location-news-show-page
Pics
Follow these steps if you are doing a Rails upgrade.