Update minitest -> v15.19.0 & mocha -> v2.1.0 #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floehopper
force-pushed
the
test-mocha-minitest-fix
branch
2 times, most recently
from
30569e6
to
68efaa2
Compare
floehopper
added a commit
to freerange/mocha
that referenced
this pull request
Jul 27, 2023
It turns out we were relying on the very old [1] MiniTest module name rather than the newer Minitest module name. While there are other places in the code that use the MiniTest form, most (all?) of those are internal to Mocha. Anyway making this one change seems to fix the problems people are having. Ideally I'd like to add a failing test to force me to make this change, but I don't have time right now and I want to fix the problem for people as soon as possible. I've run this fix against a large test suite and the build passes [2], so it doesn't feel very risky releasing this. It would also be good to do a general clean up of all the uses of MiniTest to make sure I haven't missed anything. Fixes #614. [1]: https://github.com/minitest/minitest/blob/master/History.rdoc#505--2013-06-20- [2]: alphagov/whitehall#8015
The mocha update is required to retain compatibility with minitest. See freerange/mocha#614 for more details.
floehopper
force-pushed
the
test-mocha-minitest-fix
branch
from
68efaa2
to
da7ec36
Compare
floehopper
changed the title
kevindew
approved these changes
Jul 27, 2023
ywenc
pushed a commit
to ywenc/mocha
that referenced
this pull request
Aug 10, 2023
It turns out we were relying on the very old [1] MiniTest module name rather than the newer Minitest module name. While there are other places in the code that use the MiniTest form, most (all?) of those are internal to Mocha. Anyway making this one change seems to fix the problems people are having. Ideally I'd like to add a failing test to force me to make this change, but I don't have time right now and I want to fix the problem for people as soon as possible. I've run this fix against a large test suite and the build passes [2], so it doesn't feel very risky releasing this. It would also be good to do a general clean up of all the uses of MiniTest to make sure I haven't missed anything. Fixes freerange#614. [1]: https://github.com/minitest/minitest/blob/master/History.rdoc#505--2013-06-20- [2]: alphagov/whitehall#8015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In minitest v15.19.0, the very old
MiniTestmodule name has been dropped, so we need to use theMinitestmodule name everywhere. This also requires us to upgrade mocha to v2.1.0. See freerange/mocha#614 for more details.