Improve republishing worker test coverage #8998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't used in the class and can't be used outside of it
These will be extended in a separate commit
This is a start at adding good test coverage for this class. I haven't covered the `bulk_republishing: true` conditions here. These tests also don't verify that the actions happen in the correct order - I'm not sure if there's an easy way to do that
There's an `:attr_reader` method so this is not needed
yndajas
force-pushed
the
improve-republishing-worker-test-coverage
branch
from
b9bedba
to
097e631
Compare
brucebolt
approved these changes
Apr 25, 2024
Gweaton
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was very little test coverage for the
PublishingApiDocumentRepublishingWorkerclass. I wanted to refactor it quite a bit in order to support an extension needed for a later piece of work. These tests help provide confidence that nothing will break in the later refactorThis was done as groundwork for #8993 (Trello)
Follow these steps if you are doing a Rails upgrade.